msiext Source Code Rss Feed

Patch Uploaded: #12734

amacard — Fri, 17 Aug 2012 11:54:05 GMT

amacard has uploaded a patch.

Description:
Function TcpIp_ListAddresses in SystemTools.dll Failed if computer name length is equal to 15 characters.

When computername is 15 characters GetComputerNameW function return false because size is not big enough.

Microsoft documentation says for GetComputerName parameters:

lpBuffer [out]

A pointer to a buffer that receives the computer name or the cluster virtual server name. The buffer size should be large enough to contain MAX_COMPUTERNAME_LENGTH + 1 characters.

lpnSize [in, out]

On input, specifies the size of the buffer, in TCHARs. On output, the number of TCHARs copied to the destination buffer, not including the terminating null character.

So in the code the size and buffer length are not enough big and should be:

wchar_t computername[MAX_COMPUTERNAME_LENGTH + 2] = { 0 };
DWORD size = MAX_COMPUTERNAME_LENGTH + 1;

Tested and approved !

Source code checked in, #85815

jhite — Wed, 23 Nov 2011 19:24:27 GMT

Adding new custom actions GetAccountSid and TranslateNameFormatted.

Source code checked in, #85814

jhite — Wed, 23 Nov 2011 19:23:13 GMT

Adding new custom actions GetAccountSid and TranslateNameFormatted.

Source code checked in, #79671

pguerra — Thu, 23 Jun 2011 13:11:32 GMT

Updated WhatsNew to keep consistency.

Source code checked in, #79647

dblock — Wed, 22 Jun 2011 23:46:23 GMT

Bug: ODBC custom actions, extensions and ODBQ get confused by SQL diag messages that contain brackets. Code by pguerra.

Source code checked in, #79635

pguerra — Wed, 22 Jun 2011 19:03:50 GMT

Bug: ODBC custom actions, extensions and ODBQ fail when the script output contains square brackets.

Source code checked in, #79111

pguerra — Tue, 14 Jun 2011 15:26:20 GMT

Bug: ODBC custom actions, extensions and ODBQ miss the last character of the script output when its length equals the internal buffer size.

Source code checked in, #79106

pguerra — Tue, 14 Jun 2011 14:39:52 GMT

Creating branch 1.3-wix3.0 from trunk rev 71573.

Source code checked in, #79103

pguerra — Tue, 14 Jun 2011 14:25:07 GMT

Removing branch 1.3-wix3.0.

Source code checked in, #79034

pguerra — Mon, 13 Jun 2011 16:05:00 GMT

Rev 71573.

Source code checked in, #79033

pguerra — Mon, 13 Jun 2011 15:55:36 GMT

Creating branch 1.3-wix3.0.

Source code checked in, #79032

pguerra — Mon, 13 Jun 2011 15:51:00 GMT

Removing branch 1.3-wix3.0.

Source code checked in, #79031

pguerra — Mon, 13 Jun 2011 15:03:55 GMT

Creating branch 1.3-wix3.0 from trunk rev 71573.

Source code checked in, #79030

pguerra — Mon, 13 Jun 2011 15:01:45 GMT

Removing branch 1.3-wix3.0.

Source code checked in, #78900

pguerra — Fri, 10 Jun 2011 22:52:42 GMT

Bug: ODBC custom actions, extensions and ODBQ miss the last character of the script output when its length equals the internal buffer size.

Source code checked in, #78896

pguerra — Fri, 10 Jun 2011 22:35:50 GMT

Bug: ODBC custom actions, extensions and ODBQ miss the last character of the script output when its length equals the internal buffer size.

Source code checked in, #78830

dblock — Thu, 09 Jun 2011 12:23:50 GMT

Source code checked in, #78829

dblock — Thu, 09 Jun 2011 12:23:02 GMT

Created branches.

Source code checked in, #76669

dblock — Sat, 23 Apr 2011 22:38:44 GMT

Removed sdk, unused.

Source code checked in, #76665

dblock — Sat, 23 Apr 2011 21:22:27 GMT

Removed wix 3.0 binaries.